qcdisplay 437 segfault on raw ATM data

[mggr]

See #30 for initial case and repro.

qcdisplay 4.3.7 segfaults when viewing lines in both spectral and spatial profile mode past a certain point in a file (~line 900 for the second line in day 138). This is triggered by clicking on the image widget. valgrind reports:

** End of data at error, last logr: 536944644 status: 2
==21209== 
==21209== Invalid read of size 4
==21209==    at 0x405A45E: XSetForeground (in /usr/lib/libX11.so.6.2.0)
==21209==    by 0x805C079: SpectProfDraw (in /users/rsg/arsf/usr/arsf_releases/bill-20070410/qcdisplay.4.3.7)
==21209==    by 0x805BE3C: SpectProfile (in /users/rsg/arsf/usr/arsf_releases/bill-20070410/qcdisplay.4.3.7)
==21209==    by 0x8051B0A: XLocalEvents (in /users/rsg/arsf/usr/arsf_releases/bill-20070410/qcdisplay.4.3.7)
==21209==    by 0x804A733: main (in /users/rsg/arsf/usr/arsf_releases/bill-20070410/qcdisplay.4.3.7)
==21209==  Address 0x1CBB21C0 is not stack'd, malloc'd or (recently) free'd
==21209== 
==21209== Process terminating with default action of signal 11 (SIGSEGV)
==21209==  Access not within mapped region at address 0x1CBB21C0
==21209==    at 0x405A45E: XSetForeground (in /usr/lib/libX11.so.6.2.0)
==21209==    by 0x805C079: SpectProfDraw (in /users/rsg/arsf/usr/arsf_releases/bill-20070410/qcdisplay.4.3.7)
==21209==    by 0x805BE3C: SpectProfile (in /users/rsg/arsf/usr/arsf_releases/bill-20070410/qcdisplay.4.3.7)
==21209==    by 0x8051B0A: XLocalEvents (in /users/rsg/arsf/usr/arsf_releases/bill-20070410/qcdisplay.4.3.7)
==21209==    by 0x804A733: main (in /users/rsg/arsf/usr/arsf_releases/bill-20070410/qcdisplay.4.3.7)
==21209== 
==21209== ERROR SUMMARY: 78 errors from 14 contexts (suppressed: 22 from 1)
==21209== malloc/free: in use at exit: 4,427,948 bytes in 535 blocks.
==21209== malloc/free: 777 allocs, 242 frees, 4,481,602 bytes allocated.
==21209== For counts of detected errors, rerun with: -v
==21209== searching for pointers to 535 not-freed blocks.
==21209== checked 16,650,276 bytes.
==21209== 
==21209== LEAK SUMMARY:
==21209==    definitely lost: 40,184 bytes in 138 blocks.
==21209==      possibly lost: 4,367,038 bytes in 24 blocks.
==21209==    still reachable: 20,726 bytes in 373 blocks.
==21209==         suppressed: 0 bytes in 0 blocks.
==21209== Use --leak-check=full to see details of leaked memory.
Segmentation fault

[mggr]

Contacted Bill with a bug report.

[mggr]

Workaround reversion to 436 breaks in different places - reported too.

[mggr]

Bill sent me a development version (438) to see if that helped. Unfortunately it didn't :/ Reported back a bit of extra info.

[mggr]

Dropping this bug as poor qcdisplay has many segfaulters :/